Fix RadioButtons double event emissions #189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #188
This introduces a new problem, which is that if someone programmatically sets
widget.value
toNone
, then no event will be emitted (in the GUI, this isn't possible since once a radio button is checked it can't be unchecked). quick solutions to this are made slightly challenging by the fact that we don't know if a non-None value is about to be set in the near future. Anyway, that's probably less problematic than the current behavior, so we'll leave that fix for a later PR.