-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update call button to default True when auto_call is False #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tlambert03 do you have any idea why this is failing? ________________________________ test_auto_call ________________________________
qtbot = <pytestqt.qtbot.QtBot object at 0x7fb73c51ba30>
magic_func = <FunctionGui func(a: str = 'works', b: int = 6, c=7.1) -> str>
def test_auto_call(qtbot, magic_func):
"""Test that changing a parameter calls the function."""
# TODO: remove qtbot requirement so we can test other backends eventually.
# changing the widget parameter calls the function
with qtbot.waitSignal(magic_func.called, timeout=1000):
magic_func.b.value = 6
# changing the gui calls the function
with qtbot.waitSignal(magic_func.called, timeout=1000):
> qtbot.keyClick(magic_func.a.native, Qt.Key_A, Qt.ControlModifier)
tests/test_magicgui.py:153:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
args = (<PyQt5.QtWidgets.QLineEdit object at 0x7fb73c51e1f0>, 65, 67108864)
kwargs = {}
def result(*args, **kwargs):
> return qtest_method(*args, **kwargs)
E TypeError: 'PySide2.QtTest.QTest.keyClick' called with wrong argument types:
E PySide2.QtTest.QTest.keyClick(QLineEdit, Key, KeyboardModifier)
E Supported signatures:
E PySide2.QtTest.QTest.keyClick(PySide2.QtWidgets.QWidget, PySide2.QtCore.Qt.Key, PySide2.QtCore.Qt.KeyboardModifiers = PySide2.QtCore.Qt.KeyboardModifier.NoModifier, int = -1)
E PySide2.QtTest.QTest.keyClick(PySide2.QtWidgets.QWidget, typing.Char, PySide2.QtCore.Qt.KeyboardModifiers = PySide2.QtCore.Qt.KeyboardModifier.NoModifier, int = -1)
E PySide2.QtTest.QTest.keyClick(PySide2.QtGui.QWindow, PySide2.QtCore.Qt.Key, PySide2.QtCore.Qt.KeyboardModifiers = PySide2.QtCore.Qt.KeyboardModifier.NoModifier, int = -1)
E PySide2.QtTest.QTest.keyClick(PySide2.QtGui.QWindow, typing.Char, PySide2.QtCore.Qt.KeyboardModifiers = PySide2.QtCore.Qt.KeyboardModifier.NoModifier, int = -1)
../../miniconda3/envs/all/lib/python3.8/site-packages/pytestqt/qtbot.py:626: TypeError
|
huh... looks like qtbot is using PySide2 but the widget is pyqt5 |
for more information, see https://pre-commit.ci
abb23c8
to
375323d
Compare
tlambert03
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it. thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a couple of tests failing because they didn't expect the new behavior, but getting this started.