Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete button when removing from qt RadioGroup #198

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

tlambert03
Copy link
Member

fixes #197

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #198 (27e22bd) into master (c50a7e2) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
+ Coverage   90.07%   90.20%   +0.13%     
==========================================
  Files          29       29              
  Lines        2981     2982       +1     
==========================================
+ Hits         2685     2690       +5     
+ Misses        296      292       -4     
Impacted Files Coverage Δ
magicgui/backends/_qtpy/widgets.py 87.11% <100.00%> (+0.23%) ⬆️
magicgui/application.py 83.14% <0.00%> (+2.24%) ⬆️
magicgui/backends/_qtpy/application.py 100.00% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50a7e2...27e22bd. Read the comment docs.

@tlambert03 tlambert03 merged commit d8e2c8e into pyapp-kit:master Mar 24, 2021
@tlambert03 tlambert03 deleted the fix-radiobutton-removal branch March 24, 2021 17:01
@tlambert03 tlambert03 added the bug Something isn't working label Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radiobuttons are duplicated during reset_choices in Qt <5.15.2
1 participant