Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix enum choices in radiobuttons #201

Merged
merged 3 commits into from
Mar 25, 2021

Conversation

tlambert03
Copy link
Member

this fixes a bug that @jni encountered wherein RadioButtons used with Enums weren't being populated with choices

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #201 (eea9787) into master (f6e0728) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   90.09%   90.10%           
=======================================
  Files          29       29           
  Lines        2989     2991    +2     
=======================================
+ Hits         2693     2695    +2     
  Misses        296      296           
Impacted Files Coverage Δ
magicgui/type_map.py 91.25% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6e0728...eea9787. Read the comment docs.

@jni
Copy link
Contributor

jni commented Mar 25, 2021

Works great with affinder! 😊

@tlambert03 tlambert03 merged commit b1a0fa9 into pyapp-kit:master Mar 25, 2021
jni referenced this pull request in jni/affinder Mar 25, 2021
@tlambert03 tlambert03 added the bug Something isn't working label Apr 3, 2021
@tlambert03 tlambert03 deleted the fix-enum-radiobuttons branch November 13, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants