Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coerce RadioButton with Enum/choices to RadioButtons #202

Merged
merged 5 commits into from
Mar 25, 2021

Conversation

tlambert03
Copy link
Member

With the potential confusion between widgets.RadioButton (singular) and widget.RadioButtons (plural), this PR coerces a requested widget_type of RadioButton to RadioButtons if it is associated with a choices argument or an Enum dtype.

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #202 (e051d28) into master (f0d25cd) will decrease coverage by 0.05%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   90.10%   90.04%   -0.06%     
==========================================
  Files          29       29              
  Lines        2991     2994       +3     
==========================================
+ Hits         2695     2696       +1     
- Misses        296      298       +2     
Impacted Files Coverage Δ
magicgui/type_map.py 90.18% <33.33%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d25cd...e051d28. Read the comment docs.

@tlambert03 tlambert03 merged commit e5bed49 into pyapp-kit:master Mar 25, 2021
@tlambert03 tlambert03 deleted the avoid-single-radio branch March 25, 2021 12:43
@tlambert03 tlambert03 added the enhancement New feature or request label Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant