Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reuse of magic factory #224

Merged
merged 3 commits into from
Apr 27, 2021

Conversation

tlambert03
Copy link
Member

magic_factory had a bug in which widget-specific parameters where getting cleared after the fist use of the factory 馃槵

this fixes that and adds a test.

@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/visualizing-feature-measurements-in-napari-using-colormaps-as-luts/51567/24

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #224 (25b3e33) into master (279bb3b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   90.48%   90.49%           
=======================================
  Files          28       28           
  Lines        3038     3039    +1     
=======================================
+ Hits         2749     2750    +1     
  Misses        289      289           
Impacted Files Coverage 螖
magicgui/_magicgui.py 96.29% <100.00%> (+0.06%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 279bb3b...25b3e33. Read the comment docs.

@tlambert03 tlambert03 merged commit 116dedb into pyapp-kit:master Apr 27, 2021
@tlambert03 tlambert03 deleted the fix-magicfactory-reuse branch April 27, 2021 18:41
@tlambert03 tlambert03 added the bug Something isn't working label Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants