Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RangeWidget with implicit optional type #257

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

tlambert03
Copy link
Member

This fixes failed initialization of a widget with an implied optional value, that now happens in 0.2.9:

def func(x: int = None): ...

still not sure this is the best solution, but it at least brings us back to the 0.2.8 behavior where that would make a widget with a value of 0.

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #257 (f155097) into master (4b71fc1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   90.68%   90.68%           
=======================================
  Files          28       28           
  Lines        3103     3103           
=======================================
  Hits         2814     2814           
  Misses        289      289           
Impacted Files Coverage Δ
magicgui/widgets/_bases/ranged_widget.py 85.56% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b71fc1...f155097. Read the comment docs.

@tlambert03 tlambert03 merged commit 8ff8c55 into pyapp-kit:master Jul 28, 2021
@tlambert03 tlambert03 deleted the fix-none-default branch July 28, 2021 23:16
@tlambert03 tlambert03 added the bug Something isn't working label Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant