Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional annotation affecting later widgets #262

Merged
merged 3 commits into from
Jul 28, 2021

Conversation

tlambert03
Copy link
Member

fixes #261.
was using a mutable default in the function signature

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #262 (dc5c46d) into master (fd99155) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   90.68%   90.70%   +0.01%     
==========================================
  Files          28       28              
  Lines        3103     3108       +5     
==========================================
+ Hits         2814     2819       +5     
  Misses        289      289              
Impacted Files Coverage Δ
magicgui/type_map.py 91.32% <100.00%> (+0.15%) ⬆️
magicgui/widgets/_bases/categorical_widget.py 85.29% <100.00%> (+0.21%) ⬆️
magicgui/widgets/_bases/create_widget.py 97.22% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd99155...dc5c46d. Read the comment docs.

@tlambert03 tlambert03 merged commit 49de542 into pyapp-kit:master Jul 28, 2021
@tlambert03 tlambert03 deleted the fix-leaking-options branch July 28, 2021 23:11
@tlambert03 tlambert03 added the bug Something isn't working label Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Optional annotation impact later call without Optional
1 participant