Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for Optional Type #270

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Conversation

tlambert03
Copy link
Member

fixes #269

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #270 (1711a8e) into master (481f665) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   90.28%   90.28%           
=======================================
  Files          28       28           
  Lines        3182     3182           
=======================================
  Hits         2873     2873           
  Misses        309      309           
Impacted Files Coverage Δ
magicgui/type_map.py 91.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 481f665...1711a8e. Read the comment docs.

@tlambert03 tlambert03 merged commit 6bc6f52 into pyapp-kit:master Aug 5, 2021
@tlambert03 tlambert03 deleted the fix-optional branch August 5, 2021 13:30
@tlambert03 tlambert03 added the bug Something isn't working label Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when annotating arguments with Optional[Dict]
1 participant