Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button.clicked alias for button.changed #271

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

tlambert03
Copy link
Member

closes #266

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #271 (a0566ab) into master (481f665) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
- Coverage   90.28%   90.26%   -0.03%     
==========================================
  Files          28       28              
  Lines        3182     3185       +3     
==========================================
+ Hits         2873     2875       +2     
- Misses        309      310       +1     
Impacted Files Coverage Δ
magicgui/widgets/_bases/button_widget.py 96.42% <66.66%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 481f665...a0566ab. Read the comment docs.

@tlambert03 tlambert03 merged commit 1f3a503 into pyapp-kit:master Aug 5, 2021
@tlambert03 tlambert03 deleted the clicked-alias branch August 5, 2021 13:30
@tlambert03 tlambert03 added the enhancement New feature or request label Sep 11, 2021
@tlambert03 tlambert03 changed the title Add button.clicked alias for button.changed Add button.clicked alias for button.changed Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

button.changed is unintuitive
1 participant