Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make show_file_dialog function public #274

Merged
merged 3 commits into from
Aug 22, 2021

Conversation

tlambert03
Copy link
Member

just makes show_file_dialog public in magicgui.widgets

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #274 (917b1f7) into master (6bc6f52) will decrease coverage by 0.30%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
- Coverage   90.26%   89.96%   -0.31%     
==========================================
  Files          28       29       +1     
  Lines        3185     3248      +63     
==========================================
+ Hits         2875     2922      +47     
- Misses        310      326      +16     
Impacted Files Coverage Δ
magicgui/widgets/__init__.py 100.00% <ø> (ø)
magicgui/widgets/_dialogs.py 42.85% <42.85%> (ø)
magicgui/backends/_qtpy/widgets.py 85.49% <0.00%> (-0.62%) ⬇️
magicgui/widgets/_bases/categorical_widget.py 84.50% <0.00%> (-0.57%) ⬇️
magicgui/widgets/_function_gui.py 96.87% <0.00%> (ø)
magicgui/backends/_qtpy/__init__.py 100.00% <0.00%> (ø)
magicgui/type_map.py 91.42% <0.00%> (+0.09%) ⬆️
magicgui/widgets/_concrete.py 84.27% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc6f52...917b1f7. Read the comment docs.

@tlambert03 tlambert03 merged commit 4bfefed into pyapp-kit:master Aug 22, 2021
@tlambert03 tlambert03 deleted the public-showdialog branch August 22, 2021 20:43
@tlambert03 tlambert03 added the enhancement New feature or request label Sep 11, 2021
@tlambert03 tlambert03 changed the title Make show_file_dialog public Make show_file_dialog function public Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant