Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close method #283

Merged
merged 1 commit into from
Sep 11, 2021
Merged

Add close method #283

merged 1 commit into from
Sep 11, 2021

Conversation

tlambert03
Copy link
Member

@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #283 (7a1feef) into main (8d47eba) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   89.96%   89.98%   +0.01%     
==========================================
  Files          29       29              
  Lines        3248     3254       +6     
==========================================
+ Hits         2922     2928       +6     
  Misses        326      326              
Impacted Files Coverage Δ
magicgui/backends/_qtpy/widgets.py 85.53% <100.00%> (+0.03%) ⬆️
magicgui/widgets/_bases/widget.py 87.93% <100.00%> (+0.14%) ⬆️
magicgui/widgets/_protocols.py 99.46% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d47eba...7a1feef. Read the comment docs.

@tlambert03 tlambert03 merged commit 3803ea5 into pyapp-kit:main Sep 11, 2021
@tlambert03 tlambert03 deleted the widget-close branch September 11, 2021 12:32
@tlambert03 tlambert03 added the enhancement New feature or request label Sep 11, 2021
@tlambert03 tlambert03 changed the title add close method Add close method Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant