Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stacklevel to provide better information about place of problem #302

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Add stacklevel to provide better information about place of problem #302

merged 2 commits into from
Oct 21, 2021

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Oct 21, 2021

Currently magicgui warnings point to place in magicgui code. After this change it will point to place from where function/constructor is called.

@tlambert03
Copy link
Member

thanks, much better. can release again with this if you think i should?

@tlambert03 tlambert03 merged commit 9115a07 into pyapp-kit:main Oct 21, 2021
@Czaki
Copy link
Contributor Author

Czaki commented Oct 21, 2021

I think yes. It will simplify plugin update process.

@tlambert03 tlambert03 added the enhancement New feature or request label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlambert03 tlambert03 tlambert03 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Czaki @tlambert03