-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widget demo example script #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it! I was gonna say add a slider... but I think we need to have our own API for that (rather than using "widget_type: QSlider"). So lets' add that once we have it.
thanks!
I forgot about sliders! I'm not sure what you mean by "we need to have our own API... let's add that once we have it", can you elaborate? Ideally I'd like to include as many things as possible into the examples. |
I mean that every feature should have some “magicgui” representation/API that we wouldn’t mind reusing even if we switched to another backend. So we should be able to do |
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
- Coverage 95.82% 95.77% -0.05%
==========================================
Files 14 14
Lines 934 923 -11
==========================================
- Hits 895 884 -11
Misses 39 39
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
I'm going to merge this, we can continue to embellish this example as the "showroom" script as we add more widgets and/or simplify the API. thanks @GenevieveBuckley |
I thought it would be good to have an easy to run example script showcasing all the widget types supported by
magicgui
.Right now there's nowhere in the docs or examples that explains all the different types of widgets you can have. I personally learnt most of what I know about the Gooey from their widget demo script, so that's a big motivation to include something similar here.