-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove event deprecations strategy (for release 0.4.0) #368
Remove event deprecations strategy (for release 0.4.0) #368
Conversation
Codecov Report
@@ Coverage Diff @@
## main #368 +/- ##
==========================================
- Coverage 88.30% 88.28% -0.02%
==========================================
Files 30 30
Lines 3616 3612 -4
==========================================
- Hits 3193 3189 -4
Misses 423 423
Continue to review full report at Codecov.
|
These days I noticed that the events.py broke psygnal's I then ran my test case with this PR and it also fixes |
Thanks for taking the time to let me know @aeisenbarth! I think we're pretty much in the "safe" zone for merging and releasing this with 0.4.0... likely in a couple weeks or so. |
This PR removes the
event.py
module that was mediating the deprecation strategy introduced in #253. This will make magicgui less sensitive to changes in private attributes over in psygnal. The deprecation strategy has been in place for 4 months.This is a breaking change, so the next release will be 0.4.0.