Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove event deprecations strategy (for release 0.4.0) #368

Merged
merged 10 commits into from
Mar 18, 2022

Conversation

tlambert03
Copy link
Member

This PR removes the event.py module that was mediating the deprecation strategy introduced in #253. This will make magicgui less sensitive to changes in private attributes over in psygnal. The deprecation strategy has been in place for 4 months.

This is a breaking change, so the next release will be 0.4.0.

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #368 (b20f889) into main (c4f563e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   88.30%   88.28%   -0.02%     
==========================================
  Files          30       30              
  Lines        3616     3612       -4     
==========================================
- Hits         3193     3189       -4     
  Misses        423      423              
Impacted Files Coverage Δ
magicgui/backends/_qtpy/widgets.py 86.00% <100.00%> (-0.08%) ⬇️
magicgui/widgets/_bases/button_widget.py 100.00% <100.00%> (ø)
magicgui/widgets/_bases/container_widget.py 92.85% <100.00%> (ø)
magicgui/widgets/_bases/value_widget.py 96.82% <100.00%> (ø)
magicgui/widgets/_bases/widget.py 87.15% <100.00%> (ø)
magicgui/widgets/_function_gui.py 93.99% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4f563e...b20f889. Read the comment docs.

@aeisenbarth
Copy link
Contributor

These days I noticed that the events.py broke psygnal's connect_setattr when used in MagicGUIs. The attribute setter receives an Event instead of the new attribute value. This is because _new_callback does not contain True for the setattr callback. I was just about to create a patch and then discovered this recent PR.

I then ran my test case with this PR and it also fixes connect_setattr!
Just mentioning that I'm looking forward to the release.

@tlambert03
Copy link
Member Author

Thanks for taking the time to let me know @aeisenbarth! I think we're pretty much in the "safe" zone for merging and releasing this with 0.4.0... likely in a couple weeks or so.

@tlambert03 tlambert03 requested a review from jni February 24, 2022 13:09
@tlambert03 tlambert03 merged commit 2749b2a into pyapp-kit:main Mar 18, 2022
@tlambert03 tlambert03 deleted the remove-event-deprecation branch March 18, 2022 13:08
@tlambert03 tlambert03 added the deprecated API changing label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated API changing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants