Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use empty string as null value for FileEdit #384

Merged
merged 5 commits into from
Mar 17, 2022

Conversation

brisvag
Copy link
Contributor

@brisvag brisvag commented Mar 17, 2022

Fix for issue raised on zulip, where even when setting nullable=True, None would be treated as an actual path, as well as being used as a default value. This replaces it with the empty string.

cc @VolkerH

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #384 (c5fcf7a) into main (0fa849a) will decrease coverage by 0.14%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   88.33%   88.18%   -0.15%     
==========================================
  Files          30       30              
  Lines        3610     3615       +5     
==========================================
- Hits         3189     3188       -1     
- Misses        421      427       +6     
Impacted Files Coverage Δ
magicgui/widgets/_concrete.py 84.25% <71.42%> (-0.39%) ⬇️
magicgui/_type_wrapper.py 63.76% <100.00%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fa849a...c5fcf7a. Read the comment docs.

@tlambert03
Copy link
Member

thanks! I'll deal with the typing tests later

@tlambert03 tlambert03 merged commit 9c65b23 into pyapp-kit:main Mar 17, 2022
@tlambert03 tlambert03 added the bug Something isn't working label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants