Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8-docstrings to dev requirements #39

Merged

Conversation

GenevieveBuckley
Copy link
Contributor

Add flake8-docstrings to dev requirements, so the pre-commit hook also catches docstring issues.

I was briefly confused earlier today when the qa(lint) job failed on CI for my pull request, because I had installed the pre-commit hook and flake8 magicgui passed on my local machine. Turns out that this wasn't checking any of the docstrings locally, because I did not have flake8-docstrings installed into my development environment. This PR adds flake8-docstrings to requirements/dev.txt.

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files          14       14           
  Lines         934      934           
=======================================
  Hits          895      895           
  Misses         39       39           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db4c816...7815985. Read the comment docs.

@tlambert03 tlambert03 merged commit c4a4e22 into pyapp-kit:master Jul 22, 2020
@GenevieveBuckley GenevieveBuckley deleted the requirements-flake8-docstrings branch July 22, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants