Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix of type check in ListEdit #404

Merged
merged 1 commit into from
May 18, 2022
Merged

Bug fix of type check in ListEdit #404

merged 1 commit into from
May 18, 2022

Conversation

hanjinliu
Copy link
Contributor

This PR fixes a bug in ListEdit.
I found ListEdit could not deal with type annotation of list[...] with an empty list as the default value.

@magicgui
def f(x: list[int]): ...  # OK

@magicgui
def f(x: list[int] = []): ...  # Error!

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #404 (a4f755b) into main (876190a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #404   +/-   ##
=======================================
  Coverage   88.64%   88.64%           
=======================================
  Files          30       30           
  Lines        3804     3804           
=======================================
  Hits         3372     3372           
  Misses        432      432           
Impacted Files Coverage Δ
magicgui/widgets/_concrete.py 85.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 876190a...a4f755b. Read the comment docs.

Copy link
Member

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tlambert03 tlambert03 merged commit 4ea93d7 into pyapp-kit:main May 18, 2022
@tlambert03 tlambert03 added the bug Something isn't working label Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants