Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit signal only if value of caterogical widget changed #422

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Jun 14, 2022

This is bugfix PR for not emmiting signal that value is changed if nothing changed in selection.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #422 (4c65e59) into main (d40bb0e) will increase coverage by 0.12%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
+ Coverage   88.81%   88.94%   +0.12%     
==========================================
  Files          30       30              
  Lines        3917     3926       +9     
==========================================
+ Hits         3479     3492      +13     
+ Misses        438      434       -4     
Impacted Files Coverage Δ
magicgui/backends/_qtpy/widgets.py 86.88% <92.85%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d40bb0e...4c65e59. Read the comment docs.

Copy link
Member

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Sorry for the relatively convoluted stuff going on here. I can merge this and cut 0.5.1 if you're happy with it

@Czaki
Copy link
Contributor Author

Czaki commented Jun 14, 2022

All my test works with this change.

@tlambert03 tlambert03 merged commit 1734ef3 into pyapp-kit:main Jun 14, 2022
@tlambert03 tlambert03 added the bug Something isn't working label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants