Bump jupyter-book to 0.12.x #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
force-pushed
the
jupyter-book-012
branch
from
1796cb7
to
15aa104
Compare
|
Hooray! Thanks for looking into this!! |
|
looks like no luck: https://github.com/napari/magicgui/runs/6943554562?check_suite_focus=true I'll try to take a look soon |
|
😭 well at least it's a new error 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/napari/magicgui/issues/426
The issue there was that
jupyter-book 0.11specifies sphinx<4, which is not compatable with a certain version of Jinja2 which has to be manually pinned (see sphinx-doc/sphinx#10291). Instead, bumpingjupyter-bookto 0.12 should allow useage of sphinx 4, avoiding the above error. As far as I can tell from the jupter-book changelog there's no breaking changes in this update.