Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FunctionGui behavior as a class method #443

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Fix FunctionGui behavior as a class method #443

merged 1 commit into from
Aug 2, 2022

Conversation

hanjinliu
Copy link
Contributor

Fixes #409

Will this solve all the problems of concern?

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #443 (0fa8c4e) into main (a81e1ec) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #443   +/-   ##
=======================================
  Coverage   89.02%   89.02%           
=======================================
  Files          30       30           
  Lines        3953     3953           
=======================================
  Hits         3519     3519           
  Misses        434      434           
Impacted Files Coverage Δ
magicgui/widgets/_function_gui.py 94.01% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, rookie mistake 😂 thanks @hanjinliu!

@tlambert03 tlambert03 merged commit f970453 into pyapp-kit:main Aug 2, 2022
@tlambert03 tlambert03 added the bug Something isn't working label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiple decorated class methods point to the same object
2 participants