-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add test for magic-class #447
Conversation
cc @hanjinliu ... I'd like to add this here, but it's hard to know what your test dependencies are (without trial & error and searching). If you'd like to add a |
Hi, @tlambert03 , It looks like you have found the dependencies, but I want to add that the dependencies of In my tests their testing directories are in a different places. Maybe I should somehow fix the configuration in magic-class to avoid magicgui's test being too heavy. What do you think? |
Yep, but they're necessary to run "pytest" (without ignoring specific tests), so they fall under your testing dependencies. You could either setup a It doesn't make magicgui tests any heavier, it's just one "additional " test, on top of the rest. Kinda like we test napari too. (Have a look at the workflow file here if you're curious how I'm testing). In any case, it's fine either way :). I'll keep testing it as long as it continues to be useful :) |
I see, thanks for the info! |
in addition to testing napari ...
since magic-class is a main user of magicgui, this gives us additional warning if we're breaking something for downstream devs