feat: add context manager for register_type #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #470 +/- ##
==========================================
+ Coverage 88.05% 88.08% +0.03%
==========================================
Files 31 31
Lines 4170 4189 +19
==========================================
+ Hits 3672 3690 +18
- Misses 498 499 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Czaki
reviewed
Oct 22, 2022
magicgui/type_map.py
Outdated
Comment on lines
428
to
432
| _RETURN_CALLBACKS[_type_] = prev_return_callback # type: ignore | ||
| if prev_type_def is null: | ||
| _TYPE_DEFS.pop(_type_, None) | ||
| else: | ||
| _TYPE_DEFS[_type_] = prev_type_def # type: ignore |
There was a problem hiding this comment.
looking at test and coverage messages, it looks like something is wrong. Or are default widgets stored outside _TYPE_DEFS dict?
There was a problem hiding this comment.
default widgets are stored outside of _TYPE_DEFS (for better or worse)
|
many thanks for the review @Czaki . updated |
Czaki
reviewed
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #466
@Czaki ... if you have a moment to review, it would be appreciated!