Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use parametrized generics for ListEdit and TupleEdit #500

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

tlambert03
Copy link
Member

Uses parametrized generics in place of a couple methods added just for typing in #499

@tlambert03 tlambert03 changed the title generics for containers refactor: Use parametrized generics for ListEdit and TupleEdit Nov 13, 2022
@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Base: 90.17% // Head: 90.17% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b8bd9f9) compared to base (964e697).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #500   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files          32       32           
  Lines        4232     4224    -8     
=======================================
- Hits         3816     3809    -7     
+ Misses        416      415    -1     
Impacted Files Coverage Δ
magicgui/widgets/_bases/container_widget.py 91.82% <ø> (-0.04%) ⬇️
magicgui/widgets/_concrete.py 89.21% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tlambert03 tlambert03 merged commit 14d82dc into pyapp-kit:main Nov 13, 2022
@tlambert03 tlambert03 deleted the update-types branch November 13, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant