Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix float slider readout widget for qt #511

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

tlambert03
Copy link
Member

fixes #505

it was an issue specifically with the readout widget on the qt backend

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 89.60% // Head: 89.61% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (35193c7) compared to base (18b8292).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #511   +/-   ##
=======================================
  Coverage   89.60%   89.61%           
=======================================
  Files          36       36           
  Lines        4349     4353    +4     
=======================================
+ Hits         3897     3901    +4     
  Misses        452      452           
Impacted Files Coverage Δ
src/magicgui/backends/_qtpy/widgets.py 88.23% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tlambert03 tlambert03 merged commit 376933a into pyapp-kit:main Nov 18, 2022
@tlambert03 tlambert03 deleted the fix-float-readout branch November 18, 2022 15:23
@tlambert03 tlambert03 added the bug Something isn't working label Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'FloatSlider' widget crash when setting up a minimum value
1 participant