Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make ValueWidget a Generic #517

Merged
merged 1 commit into from
Nov 27, 2022
Merged

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Nov 27, 2022

adds Generic typing to ValueWidget

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Base: 89.77% // Head: 89.78% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (553f2a4) compared to base (05dd1a1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
+ Coverage   89.77%   89.78%   +0.01%     
==========================================
  Files          37       37              
  Lines        4450     4456       +6     
==========================================
+ Hits         3995     4001       +6     
  Misses        455      455              
Impacted Files Coverage Δ
src/magicgui/type_map/_type_map.py 96.48% <ø> (ø)
src/magicgui/widgets/_concrete.py 89.10% <100.00%> (+0.04%) ⬆️
src/magicgui/widgets/_function_gui.py 93.75% <100.00%> (ø)
src/magicgui/widgets/bases/_button_widget.py 100.00% <100.00%> (ø)
src/magicgui/widgets/bases/_categorical_widget.py 84.00% <100.00%> (ø)
src/magicgui/widgets/bases/_create_widget.py 97.50% <100.00%> (ø)
src/magicgui/widgets/bases/_ranged_widget.py 88.23% <100.00%> (ø)
src/magicgui/widgets/bases/_slider_widget.py 96.96% <100.00%> (+0.30%) ⬆️
src/magicgui/widgets/bases/_value_widget.py 98.36% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tlambert03 tlambert03 merged commit f46c574 into pyapp-kit:main Nov 27, 2022
@tlambert03 tlambert03 deleted the generics branch November 27, 2022 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant