Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable strict mypy type checking for most modules #518

Merged
merged 12 commits into from
Nov 27, 2022

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Nov 27, 2022

tried hard not to touch anything functional. Should be mostly just typing, with a couple of sourcery updates

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Base: 89.78% // Head: 89.83% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (24c80c8) compared to base (f46c574).
Patch coverage: 95.25% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
+ Coverage   89.78%   89.83%   +0.04%     
==========================================
  Files          37       37              
  Lines        4456     4407      -49     
==========================================
- Hits         4001     3959      -42     
+ Misses        455      448       -7     
Impacted Files Coverage Δ
src/magicgui/_util.py 74.64% <78.57%> (+0.73%) ⬆️
src/magicgui/widgets/_dialogs.py 80.95% <80.00%> (-0.87%) ⬇️
src/magicgui/signature.py 96.62% <85.71%> (ø)
src/magicgui/type_map/_type_map.py 96.48% <88.88%> (ø)
src/magicgui/widgets/bases/_ranged_widget.py 88.70% <89.47%> (+0.47%) ⬆️
src/magicgui/widgets/bases/_categorical_widget.py 84.50% <91.66%> (+0.50%) ⬆️
src/magicgui/widgets/_table.py 96.14% <91.80%> (-0.05%) ⬇️
src/magicgui/widgets/_function_gui.py 93.69% <93.33%> (-0.06%) ⬇️
src/magicgui/widgets/bases/_widget.py 87.93% <95.83%> (ø)
src/magicgui/widgets/_concrete.py 88.93% <96.49%> (-0.18%) ⬇️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tlambert03 tlambert03 changed the title refactor: working on enabling strict mypy for many modules refactor: enable strict mypy type checking for most modules Nov 27, 2022
@tlambert03 tlambert03 merged commit 2d42d1e into pyapp-kit:main Nov 27, 2022
@tlambert03 tlambert03 deleted the update-lint branch November 27, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant