Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and add codespell pre-commit hook #522

Merged

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Dec 2, 2022

Typos found via codespell -S .mypy_cache

Note that I've encountered this while running pre-commit:

mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

src/magicgui/widgets/_docs_sigs.py:28: error: Item "None" of "Optional[Any]"
has no attribute "__origin__"  [union-attr]
                        if valtype.__bound__.__origin__ is Union:
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/magicgui/widgets/_docs_sigs.py:30: error: Item "None" of "Optional[Any]"
has no attribute "__args__"  [union-attr]
    ...                       [str(c.__name__) for c in valtype.__bound__.__a...
                                                        ^~~~~~~~~~~~~~~~~~~~~...
Found 2 errors in 1 file (checked 42 source files)

@tlambert03
Copy link
Member

Thanks @kianmeng

@tlambert03 tlambert03 enabled auto-merge (squash) December 3, 2022 14:39
@tlambert03 tlambert03 merged commit a3bdc90 into pyapp-kit:main Dec 3, 2022
@kianmeng
Copy link
Contributor Author

kianmeng commented Dec 4, 2022

🥳 🥳 🥳 🥳 🥳

@tlambert03 tlambert03 added the bug Something isn't working label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants