fix: Support nested Annotated types
#536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 89.65% // Head: 89.63% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
==========================================
- Coverage 89.65% 89.63% -0.02%
==========================================
Files 37 37
Lines 4417 4420 +3
==========================================
+ Hits 3960 3962 +2
- Misses 457 458 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tlambert03
reviewed
Feb 24, 2023
| # nested Annotated type results in multiple dicts. | ||
| annotation, *anno_options = get_args(annotation) | ||
| for opt in anno_options: | ||
| if not isinstance(opt, dict): |
There was a problem hiding this comment.
hmm... was I doing this when it worked before? I'm not sure I want to prevent people from using Annotated for any other reason.
There was a problem hiding this comment.
Eh, I guess I'm already preventing it 😂 let's go with it!
tlambert03
approved these changes
Feb 24, 2023
tlambert03
changed the title
Annotated typesAnnotated types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #535 .
get_argsreturns multiple options ifAnnotatedis nested. We can also easily support annotated-types in the future because it also uses multiple options likeAnnotated[int, Gt(3), Lt(10)](raises a TypeError for now).