fix: fix binding of non ValueWidgets in guiclass #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
=======================================
Coverage 89.76% 89.76%
=======================================
Files 37 37
Lines 4434 4437 +3
=======================================
+ Hits 3980 3983 +3
Misses 454 454
☔ View full report in Codecov by Sentry. |
|
Awesome work - thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #555
the deeper issue is that FileEdit implements a very similar protocol to ValueWidget (has a
changedevent andvalue), but doesn't subclass it... so changes to the widget weren't getting bound to the model.