Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected usage / example code of parameter 'choices' #57

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

haesleinhuepf
Copy link
Contributor

Hi Talley @tlambert03 ,

when I derived code from this example, I stumbled over that "arg" variable name here. I think it's better explained like this.

Cheers,
Robert

When I derived code from this example, I was stumbling over that "arg" variable name here. I _think_ it's better explained like this.
@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #57 (d234a85) into master (008b0c7) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   77.57%   77.52%   -0.06%     
==========================================
  Files          16       16              
  Lines        1793     1793              
==========================================
- Hits         1391     1390       -1     
- Misses        402      403       +1     
Impacted Files Coverage Δ
magicgui/type_map.py 90.97% <0.00%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 008b0c7...d234a85. Read the comment docs.

@tlambert03
Copy link
Member

indeed it is! thanks! I'm in the process of rewriting the docs at this very moment... and will make sure this gets incorporated there as well

@tlambert03 tlambert03 merged commit c39c611 into pyapp-kit:master Dec 18, 2020
@haesleinhuepf haesleinhuepf deleted the patch-1 branch December 18, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants