fix: Allow user to overwrite default widget opts #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
=======================================
Coverage 87.98% 87.98%
=======================================
Files 39 39
Lines 4609 4609
=======================================
Hits 4055 4055
Misses 554 554
☔ View full report in Codecov by Sentry. |
|
It looks like a failure of the docs is unrelated to PR. |
|
Since the pr is mostly rename now, can you point out which part specifically fixes the napari issue ? |
Czaki
commented
Oct 20, 2023
| widget_type_ = match_type(type_, value) | ||
| if widget_type_: | ||
| cls_, opts = widget_type_ | ||
| return cls_, {**opts, **options} |
| widget_type_ = match_return_type(type_) | ||
| if widget_type_: | ||
| cls_, opts = widget_type_ | ||
| return cls_, {**opts, **options} |
There was a problem hiding this comment.
and here same change, but it is not the code branch reached by the original issue.
|
the change is to change |
|
thanks! |
tlambert03
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes napari/napari#6354
It also renamems multiple variables starting from
_to ending with_as it is convention to use leading underscore as an unused variable when it is a local variable in functions so make it harder for me to follow flow of code.