Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for docs and examples #68

Merged
merged 7 commits into from
Dec 29, 2020
Merged

Conversation

tlambert03
Copy link
Member

This PR adds two more tests that make sure all of the {code-cell} blocks in the docs, and all of the *.py files in the examples folder run without errors or warnings (unless specifically expected to)

@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #68 (f134bfa) into master (002f973) will increase coverage by 2.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   85.07%   87.22%   +2.14%     
==========================================
  Files          15       15              
  Lines        1588     1589       +1     
==========================================
+ Hits         1351     1386      +35     
+ Misses        237      203      -34     
Impacted Files Coverage Δ
magicgui/widgets/_concrete.py 82.67% <100.00%> (+3.07%) ⬆️
magicgui/backends/_qtpy/widgets.py 83.12% <0.00%> (+0.41%) ⬆️
magicgui/widgets/_bases.py 89.31% <0.00%> (+2.35%) ⬆️
magicgui/backends/_qtpy/application.py 91.66% <0.00%> (+2.77%) ⬆️
magicgui/type_map.py 94.73% <0.00%> (+3.00%) ⬆️
magicgui/function_gui.py 91.66% <0.00%> (+9.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 002f973...f134bfa. Read the comment docs.

@tlambert03 tlambert03 changed the title add tests for docs and examples Add tests for docs and examples Dec 27, 2020
Copy link
Contributor

@sofroniewn sofroniewn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tlambert03 tlambert03 merged commit 90b5ced into pyapp-kit:master Dec 29, 2020
@tlambert03 tlambert03 deleted the test-docs branch December 29, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants