Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #70

Merged
merged 10 commits into from
Dec 27, 2020
Merged

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Dec 27, 2020

Just regaining some of the coverage that was lost in #43...
there are two or three very small bugs that are fixed here as well

@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #70 (e88c4d3) into master (c441861) will increase coverage by 7.68%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   77.39%   85.07%   +7.68%     
==========================================
  Files          16       15       -1     
  Lines        1964     1588     -376     
==========================================
- Hits         1520     1351     -169     
+ Misses        444      237     -207     
Impacted Files Coverage Δ
magicgui/widgets/_bases.py 86.96% <85.71%> (+10.09%) ⬆️
magicgui/backends/_qtpy/widgets.py 82.71% <100.00%> (+4.20%) ⬆️
magicgui/type_map.py 91.72% <100.00%> (+0.06%) ⬆️
magicgui/_qt/widgets.py 0.00% <0.00%> (ø)
magicgui/events.py
magicgui/function_gui.py 82.50% <0.00%> (+1.19%) ⬆️
magicgui/widgets/_concrete.py 79.60% <0.00%> (+2.41%) ⬆️
magicgui/backends/_qtpy/application.py 88.88% <0.00%> (+2.77%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c441861...e88c4d3. Read the comment docs.

@tlambert03 tlambert03 merged commit 002f973 into pyapp-kit:master Dec 27, 2020
@tlambert03 tlambert03 deleted the improve-coverage branch December 27, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant