Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipywidgets backend #87

Merged
merged 31 commits into from
Sep 21, 2022
Merged

Add ipywidgets backend #87

merged 31 commits into from
Sep 21, 2022

Conversation

tlambert03
Copy link
Member

This PR will add ipywidgets as a widget backend for the jupyter environment (using magicgui.use_app('ipynb')). Things are coming together pretty well, with most widgets and events working nicely:

ipynb_magicgui.mov

@jni
Copy link
Contributor

jni commented Jan 7, 2021

😍

@tlambert03 tlambert03 marked this pull request as ready for review September 18, 2022 14:01
@tlambert03
Copy link
Member Author

Hey @Czaki, if you have a moment to review this, mostly paying attention to the minimal changes outside of the new backends/_ipynb directory (i.e. the stuff that has any potential to interact with existing non-notebook usage) that would be great.

Since it's a new/independent feature that doesn't really affect much of the Qt-based usage, I'll probably merge this soon to make it available for playing with

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #87 (288e0d0) into main (284999e) will decrease coverage by 1.68%.
The diff coverage is 64.15%.

❗ Current head 288e0d0 differs from pull request most recent head 080e366. Consider uploading reports for the commit 080e366 to get more accurate results

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   89.02%   87.33%   -1.69%     
==========================================
  Files          30       33       +3     
  Lines        3953     4208     +255     
==========================================
+ Hits         3519     3675     +156     
- Misses        434      533      +99     
Impacted Files Coverage Δ
magicgui/widgets/_bases/widget.py 84.92% <26.66%> (-2.98%) ⬇️
magicgui/backends/_ipynb/widgets.py 63.91% <63.91%> (ø)
magicgui/backends/_ipynb/application.py 90.90% <90.90%> (ø)
magicgui/backends/__init__.py 100.00% <100.00%> (ø)
magicgui/backends/_ipynb/__init__.py 100.00% <100.00%> (ø)
magicgui/backends/_qtpy/widgets.py 86.95% <100.00%> (ø)
magicgui/widgets/__init__.py 100.00% <100.00%> (ø)
magicgui/widgets/_bases/button_widget.py 100.00% <100.00%> (ø)
magicgui/widgets/_protocols.py 100.00% <100.00%> (ø)
magicgui/_type_wrapper.py 65.70% <0.00%> (-2.53%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Czaki Czaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything that I could find.

magicgui/widgets/_bases/button_widget.py Outdated Show resolved Hide resolved
magicgui/backends/_ipynb/widgets.py Outdated Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
tests/test_widgets.py Outdated Show resolved Hide resolved
@tlambert03
Copy link
Member Author

thanks @Czaki ... i made all the changes requested

@tlambert03 tlambert03 merged commit 83f9ab0 into pyapp-kit:main Sep 21, 2022
@tlambert03 tlambert03 deleted the ipynb branch September 21, 2022 16:08
@tlambert03 tlambert03 added the enhancement New feature or request label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants