Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ComboBox with unhashable choice data #89

Merged
merged 3 commits into from
Jan 6, 2021

Conversation

tlambert03
Copy link
Member

This allows the "data" for one of the choices in a categorical widget to be unhashable.
(for instance combo.choices = (('a', [1,2,3]), ('b', [3,4,5)))

This is necessary to implement the napari feature requested by @sofroniewn here

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #89 (d7ed4f2) into master (ce7346a) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   86.64%   86.90%   +0.26%     
==========================================
  Files          15       15              
  Lines        1670     1673       +3     
==========================================
+ Hits         1447     1454       +7     
+ Misses        223      219       -4     
Impacted Files Coverage Δ
magicgui/backends/_qtpy/widgets.py 84.04% <100.00%> (+1.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce7346a...f412467. Read the comment docs.

Copy link
Contributor

@sofroniewn sofroniewn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tlambert03. LGTM!

@tlambert03 tlambert03 merged commit f2368b9 into pyapp-kit:master Jan 6, 2021
@tlambert03 tlambert03 deleted the fix-unhashable-choices branch January 6, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants