-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete leftover plots #21
Delete leftover plots #21
Conversation
Codecov Report
@@ Coverage Diff @@
## issue-16-add-parameters-to-vary #21 +/- ##
=================================================================
Coverage 100.00% 100.00%
=================================================================
Files 12 12
Lines 387 407 +20
=================================================================
+ Hits 387 407 +20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Saransh!
bot/plotting/comparison_generator.py
Outdated
param_value == 0 | ||
or param_value < 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any particular reason to not use <=
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No particular reason, a silly mistake:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically it is not a mistake haha
Fixes #19
Added code to delete all the PNGs if they are leftover while testing.