#633 fixed small comments

pybamm-team · Oct 11, 2019 · 70b0d11 · 70b0d11
1 parent 1173d69
commit 70b0d11
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/examples/scripts/compare-dae-solver.py b/examples/scripts/compare-dae-solver.py
@@ -28,8 +28,8 @@
 # solve model
 t_eval = np.linspace(0, 0.2, 100)
 
-klu_sol = pybamm.KLU(tol=1e-8).solve(model, t_eval)
-scikits_sol = pybamm.ScikitsDaeSolver(tol=1e-8).solve(model, t_eval)
+klu_sol = pybamm.KLU(atol=1e-8, rtol=1e-8).solve(model, t_eval)
+scikits_sol = pybamm.ScikitsDaeSolver(atol=1e-8, rtol=1e-8).solve(model, t_eval)
 
 # plot
 models = [model, model]

diff --git a/pybamm/solvers/klu_sparse_solver.py b/pybamm/solvers/klu_sparse_solver.py
@@ -68,6 +68,12 @@ def integrate(self, residuals, y0, t_eval, events, mass_matrix, jacobian):
             (see `SUNDIALS docs. <https://computation.llnl.gov/projects/sundials>`).
         """
 
+        if not jacobian:
+            pybamm.SolverError("KLU requires the Jacobian to be provided")
+
+        if not events:
+            pybamm.SolverError("KLU requires events to be provided")
+
         def eqsres(t, y, ydot, return_residuals):
             return_residuals[:] = residuals(t, y, ydot)
 

diff --git a/tests/integration/test_solvers/test_klu.py b/tests/integration/test_solvers/test_klu.py
@@ -4,7 +4,7 @@
 import unittest
 
 
-@unittest.skipIf(pybamm.have_klu(), "klu is not installed")
+@unittest.skipIf(pybamm.have_klu(), "klu solver is not installed")
 class TestKLUSolver(unittest.TestCase):
     def test_on_spme(self):
         model = pybamm.lithium_ion.SPMe()

diff --git a/tests/unit/test_solvers/test_klu_sparse_solver.py b/tests/unit/test_solvers/test_klu_sparse_solver.py
@@ -7,7 +7,7 @@
 import unittest
 
 
-@unittest.skipIf(pybamm.have_klu(), "klu is not installed")
+@unittest.skipIf(pybamm.have_klu(), "klu solver is not installed")
 class TestKLUSolver(unittest.TestCase):
     def test_ida_roberts_klu(self):
         # this test implements a python version of the ida Roberts