Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set CMAKE_BUILD_PARALLEL_LEVEL to speed up SUNDIALS and IDAKLU compilation #3646

Closed
agriyakhetarpal opened this issue Dec 20, 2023 · 0 comments · Fixed by #3569
Closed

Set CMAKE_BUILD_PARALLEL_LEVEL to speed up SUNDIALS and IDAKLU compilation #3646

agriyakhetarpal opened this issue Dec 20, 2023 · 0 comments · Fixed by #3569
Assignees
@agriyakhetarpal
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows

Comments

@agriyakhetarpal
Copy link
Member

agriyakhetarpal commented Dec 20, 2023 •
edited
Loading

THE CMAKE_BUILD_PARALLEL_LEVEL (CMake 3.12+) environment variable provides immense speedups (in the order of ~3x in my case) in the compilation of SuiteSparse and SUNDIALS if set, with the use of multithreaded builds – we can use this environment variable in install_KLU_Sundials.py, and for the IDAKLU extension module compilation in the build_ext command classes in setup.py.

The value of the environment variable should be set to the number of CPU cores present on the machine (computed through the value of multiprocessing.cpu_count() or similar).

Addendum: it can also be set accordingly in pybamm/install_odes.py to speed up the compilation of SUNDIALS for user installations.
@agriyakhetarpal agriyakhetarpal added difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows labels Dec 20, 2023
@agriyakhetarpal agriyakhetarpal changed the title Set CMAKE_BUILD_PARALLEL_LEVEL to speed up SUNDIALS and IDAKLU compilation Set CMAKE_BUILD_PARALLEL_LEVEL to speed up SUNDIALS and IDAKLU compilation Dec 20, 2023
@agriyakhetarpal agriyakhetarpal self-assigned this Dec 21, 2023
@agriyakhetarpal agriyakhetarpal linked a pull request Dec 21, 2023 that will close this issue
i3558 improve wheel repair + add minimal IDAKLU test for built wheels #3569
Merged
6 tasks
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 21, 2023
@agriyakhetarpal
pybamm-team#3646 fix parallel level, set environment variable
a04fce6
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 21, 2023
@agriyakhetarpal
pybamm-team#3646 set parallel variable for build_ext (IDAKLU)
3dc8c8c
@agriyakhetarpal agriyakhetarpal mentioned this issue Dec 21, 2023
Closed
5 tasks
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 23, 2023
@agriyakhetarpal
pybamm-team#3646 set parallel jobs for pybamm_install_odes
139e34d
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 23, 2023
@agriyakhetarpal
pybamm-team#3646 set parallel jobs for install_sundials.sh
971ef8a 
for Linux wheel builds
@agriyakhetarpal agriyakhetarpal mentioned this issue Dec 23, 2023
Merged
8 tasks
@arjxn-py arjxn-py mentioned this issue Jan 6, 2024
Merged
6 tasks
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Jan 6, 2024
@agriyakhetarpal
pybamm-team#3646 set CMake parallelism for Windows wheels
9017c21
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Jan 6, 2024
@agriyakhetarpal
pybamm-team#3646 Use os.cpu_count rather than processor affinity
cb3092a
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Jan 6, 2024
@agriyakhetarpal
pybamm-team#3646 Use os.cpu_count rather than processor affinity
7c82e87
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Jan 6, 2024
@agriyakhetarpal
pybamm-team#3646 Use os.cpu_count rather than processor affinity
aa87d69
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Jan 6, 2024
@agriyakhetarpal
pybamm-team#3646 Use os.cpu_count rather than processor affinity
632bcec
@agriyakhetarpal agriyakhetarpal mentioned this issue Feb 7, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agriyakhetarpal agriyakhetarpal

Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i3558 improve wheel repair + add minimal IDAKLU test for built wheels agriyakhetarpal/PyBaMM
1 participant
@agriyakhetarpal