Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some annoying bugs from trying fuel cell models #846

Closed
valentinsulzer opened this issue Feb 20, 2020 · 1 comment · Fixed by #876
Closed

Some annoying bugs from trying fuel cell models #846

valentinsulzer opened this issue Feb 20, 2020 · 1 comment · Fixed by #876

Comments

@valentinsulzer
Copy link
Member

valentinsulzer commented Feb 20, 2020 •
edited

  • Obscure error if a Variable is included in the variables list but not in the model rhs/algebraic
  • Path to parameters doesn't get set right
  • process_binary_operators doesn't work with Heaviside operator
  • make it obvious that quickplot time is in hours
valentinsulzer added a commit that referenced this issue Feb 21, 2020
@valentinsulzer
#846 tackle some of the bugs
1dd5ecd
valentinsulzer added a commit that referenced this issue Feb 21, 2020
@valentinsulzer
#846 add more informative error for discretisation failure
1f53aac
valentinsulzer added a commit that referenced this issue Feb 24, 2020
@valentinsulzer
#846 fix accidentally broken convection model
98bab54
valentinsulzer added a commit that referenced this issue Feb 24, 2020
@valentinsulzer
#846 fix dfn example
c03af62
@valentinsulzer
Copy link
Member Author

valentinsulzer commented Feb 24, 2020 •
edited

  • allow different names for spatial variables
  • generalize x_average
  • ignore discontinuities in the solver if no time dependence

valentinsulzer added a commit that referenced this issue Feb 25, 2020
@valentinsulzer
#846 windows test and skipping non-time discontinuities
da91cd9
valentinsulzer added a commit that referenced this issue Feb 25, 2020
@valentinsulzer
#846 generalized x_average
10ddc82
valentinsulzer added a commit that referenced this issue Mar 2, 2020
@valentinsulzer
#846 merge master
30aa25c
valentinsulzer added a commit that referenced this issue Mar 2, 2020
@valentinsulzer
#846 merge 830
eb251ae
valentinsulzer added a commit that referenced this issue Mar 2, 2020
@valentinsulzer
#846 changelog
21d6ad3
@valentinsulzer valentinsulzer mentioned this issue Mar 9, 2020
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Mar 9, 2020
@valentinsulzer
#846 changelog
6c73878
valentinsulzer added a commit that referenced this issue Mar 10, 2020
@valentinsulzer
#846 coverage
3d7bc4a
valentinsulzer added a commit that referenced this issue Mar 10, 2020
@valentinsulzer
#846 merge
b52353f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 846 bugs pybamm-team/PyBaMM
1 participant
@valentinsulzer