Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPMe electrolyte model with general Ohmic term #884

Closed
brosaplanella opened this issue Mar 12, 2020 · 0 comments · Fixed by #1188
Closed

SPMe electrolyte model with general Ohmic term #884

brosaplanella opened this issue Mar 12, 2020 · 0 comments · Fixed by #1188
Assignees
@brosaplanella

Comments

@brosaplanella
Copy link
Sponsor Member

Summary
The electrolyte potential in the SPMe can be calculated without any further assumptions about the conductivity being constant or the variation in the concentration small. Then, the Ohmic term is an integral.

Motivation
I want to implement this submodel and compare it with the existing ones to see if there is a significant improvement in the electrolyte potential at moderately high C-rates.

Additional context
Add any other context or screenshots about the feature request here.
@brosaplanella brosaplanella self-assigned this Mar 12, 2020
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Apr 22, 2020
@brosaplanella
pybamm-team#884 added integrated conductivity model
92de548
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue May 16, 2020
@brosaplanella
pybamm-team#884 debugging new submodel
e5d7c14
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue May 19, 2020
@brosaplanella
pybamm-team#884 added integrated conductivity model
fb667b3
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue May 19, 2020
@brosaplanella
pybamm-team#884 debugging new submodel
7899fdd
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue May 20, 2020
@brosaplanella
pybamm-team#884 added integrated conductivity model
573db34
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue May 20, 2020
@brosaplanella
pybamm-team#884 debugging new submodel
eec8354
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue May 26, 2020
@brosaplanella
pybamm-team#884 added integrated conductivity model
3eb9c68
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue May 26, 2020
@brosaplanella
pybamm-team#884 debugging new submodel
4a3ebf7
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue May 28, 2020
@brosaplanella
pybamm-team#884 added integrated conductivity model
5548930
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue May 28, 2020
@brosaplanella
pybamm-team#884 debugging new submodel
4c10748
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 10, 2020
@brosaplanella
pybamm-team#884 added integrated conductivity model
e7897be
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 10, 2020
@brosaplanella
pybamm-team#884 debugging new submodel
428e4aa
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#884 fixed the new SPMe model to work with the new geometry
320804b
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#884 added integrated conductivity model
bf92330
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#884 debugging new submodel
44bdd41
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#884 added integrated conductivity model
90eb3ee
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#884 debugging new submodel
7b55d57
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#884 fixed the new SPMe model to work with the new geometry
a923ca7
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#884 cleaned code
764fcec
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#884 added integrated conductivity model
96eb696
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#884 debugging new submodel
183a765
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#884 fixed the new SPMe model to work with the new geometry
a92fcf8
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#884 added integrated conductivity model
8dc661f
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#884 debugging new submodel
fb4f6d9
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#884 cleaned code
71d7a03
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#884 renamed model
d8108e8
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#884 added integrated conductivity model
6ec5ce6
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#884 debugging new submodel
4a6874f
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#884 fixed the new SPMe model to work with the new geometry
51f71c4
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#884 cleaned code
466e502
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#884 debugging new submodel
d11e266
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#884 added integrated conductivity model
1521a3f
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#884 debugging new submodel
85c77e7
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#884 cleaned code
1ae86bb
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#884 renamed model
62c52ea
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 13, 2020
@brosaplanella
pybamm-team#884 tidy up for merge
f4ba84e
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 13, 2020
@brosaplanella
pybamm-team#884 removed SPME_FBP (for development only)
cf39650
@brosaplanella brosaplanella mentioned this issue Oct 13, 2020
Merged
6 tasks
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 13, 2020
@brosaplanella
pybamm-team#884 add preliminary citation
756e093
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 13, 2020
@brosaplanella
pybamm-team#884 add test
9d08f5e
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 13, 2020
@brosaplanella
pybamm-team#884 removed activation energy from Nyman2008
0d19dbc
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 19, 2020
@brosaplanella
pybamm-team#884 update CHANGELOG
e615e4a
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 20, 2020
@brosaplanella
pybamm-team#884 add docs
08d191c
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 20, 2020
@brosaplanella
pybamm-team#884 removed arrhenius term
6a89b7d
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 20, 2020
@brosaplanella
pybamm-team#884 included docstring reference
3f04c15
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 20, 2020
@brosaplanella
pybamm-team#884 removed redundant right boundary integrals
86051b9
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 20, 2020
@brosaplanella
pybamm-team#884 added SPMe tests
a019e6b
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 20, 2020
@brosaplanella
pybamm-team#884 fixed typo in docs
4890bab
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 20, 2020
@brosaplanella
pybamm-team#884 fix documentation
f35dd26
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 22, 2020
@brosaplanella
pybamm-team#884 added options to set integrated conductivity
30ab27c
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 23, 2020
@brosaplanella
pybamm-team#884 pybamm-team#1207 implemented option to choose electro…
6aa1bb3 
…lyte conductivity and made it compatible with surface form
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 23, 2020
@brosaplanella
pybamm-team#884 set SPMe surface form to NotImplemented for the moment
006dc25
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 23, 2020
@brosaplanella
pybamm-team#884 update CHANGELOG
480765f
@brosaplanella brosaplanella mentioned this issue Oct 23, 2020
Closed
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 23, 2020
@brosaplanella
pybamm-team#884 removed SPMe from test_compare_outputs for surface form
3afea4e
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 27, 2020
@brosaplanella
pybamm-team#884 fix typo CITATIONS.txt
c301814
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Nov 4, 2020
@brosaplanella
pybamm-team#884 add test citation Brosa Planella 2020
f67357b
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Nov 4, 2020
@brosaplanella
pybamm-team#884 update citation TSPMe
5d4bd51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brosaplanella brosaplanella

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Integrated electrolyte conductivity brosaplanella/PyBaMM
1 participant
@brosaplanella