Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1030 length scales models #1058

Merged
merged 9 commits into from
Jun 16, 2020

Conversation

valentinsulzer
Copy link
Member

Description

Add length scales to the models, in the same way as timescale.
Also fixes a few minor things in quickplot

Fixes #1030

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #1058 into develop will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1058      +/-   ##
===========================================
- Coverage    97.72%   97.72%   -0.01%     
===========================================
  Files          237      237              
  Lines        12426    12413      -13     
===========================================
- Hits         12143    12130      -13     
  Misses         283      283              
Impacted Files Coverage Δ
...models/full_battery_models/lead_acid/basic_full.py 100.00% <ø> (ø)
pybamm/models/base_model.py 98.82% <100.00%> (+<0.01%) ⬆️
...l_battery_models/lead_acid/base_lead_acid_model.py 100.00% <100.00%> (ø)
...ttery_models/lithium_ion/base_lithium_ion_model.py 100.00% <100.00%> (ø)
pybamm/parameters/parameter_values.py 99.30% <100.00%> (+<0.01%) ⬆️
pybamm/plotting/quick_plot.py 100.00% <100.00%> (ø)
pybamm/solvers/processed_variable.py 99.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00cbe19...9aa952c. Read the comment docs.

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks @tinosulzer !

@valentinsulzer valentinsulzer merged commit 50fb37e into develop Jun 16, 2020
@valentinsulzer valentinsulzer deleted the issue-1030-length-scales-models branch June 16, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add length scales to models
2 participants