Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1126 upwind #1134

Merged
merged 12 commits into from Sep 3, 2020
Merged

Issue 1126 upwind #1134

merged 12 commits into from Sep 3, 2020

Conversation

valentinsulzer
Copy link
Member

Description

Add upwind and downwind operators for convection.

Fixes #1126

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@377fc45). Click here to learn what that means.
The diff coverage is 98.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1134   +/-   ##
==========================================
  Coverage           ?   97.92%           
==========================================
  Files              ?      247           
  Lines              ?    13957           
  Branches           ?        0           
==========================================
  Hits               ?    13668           
  Misses             ?      289           
  Partials           ?        0           
Impacted Files Coverage Δ
pybamm/expression_tree/binary_operators.py 95.27% <75.00%> (ø)
pybamm/discretisations/discretisation.py 99.78% <100.00%> (ø)
pybamm/expression_tree/unary_operators.py 100.00% <100.00%> (ø)
pybamm/plotting/quick_plot.py 100.00% <100.00%> (ø)
pybamm/spatial_methods/finite_volume.py 97.95% <100.00%> (ø)
pybamm/install_odes.py 0.00% <0.00%> (ø)
pybamm/parameters/parameter_values.py 99.29% <0.00%> (ø)
...graphite_UMBL_Mohtat2020/graphite_ocp_PeymanMPM.py 100.00% <0.00%> (ø)
pybamm/solvers/casadi_solver.py 100.00% <0.00%> (ø)
...ectrolyte_exchange_current_density_Dualfoil1998.py 100.00% <0.00%> (ø)
... and 242 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 377fc45...6ac182b. Read the comment docs.

@valentinsulzer valentinsulzer requested review from rtimms and brosaplanella and removed request for rtimms September 1, 2020 13:04
Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tinosulzer !

@valentinsulzer valentinsulzer merged commit b9db700 into develop Sep 3, 2020
@valentinsulzer valentinsulzer deleted the issue-1126-upwind branch September 3, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add upwinding and downwinding operators for convection-dominated flow
2 participants