Fix boundary condition types

[bessman]

Description

Change boundary condition type in "Creating Models" notebooks, which were incorrectly given as Dirichlet but are in fact Neumann.

Note that this change does not affect the final result of any of the notebooks; the fact that the result is independent of boundary condition type is probably a bug. See also #1174.

Type of change

• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

I have one failing test (test_add_rm_param) and one which errors (test_edit_param), but on my system this is the case prior to this PR too.

[brosaplanella]

Looks good, thanks @bessman!

[brosaplanella]

Related to the test_add_rm_param error, which PyBaMM version are you using? You might need to reinstall PyBaMM to fix it.

[valentinsulzer]

Thanks @bessman !

[bessman]

@ferranbrosa I'm on develop, 87dc41a specifically.

Here are the errors:

test_add_rm_param (test_parameters.test_parameters_cli.TestParametersCLI) ... FAIL
/usr/lib/python3.7/tempfile.py:935: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpleeb5c96'>
  _warnings.warn(warn_message, ResourceWarning)
test_edit_param (test_parameters.test_parameters_cli.TestParametersCLI) ... ERROR
/usr/lib/python3.7/tempfile.py:935: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/home/alexander/projects/pybamm/pybamm/input/parameters/lithium-ion/anodes/tmpkrmqmi1z'>
  _warnings.warn(warn_message, ResourceWarning)
/usr/lib/python3.7/tempfile.py:935: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpcaxjpoav'>
  _warnings.warn(warn_message, ResourceWarning)

...

======================================================================
ERROR: test_edit_param (test_parameters.test_parameters_cli.TestParametersCLI)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/alexander/projects/pybamm/tests/unit/test_parameters/test_parameters_cli.py", line 100, in test_edit_param
    with open(copied_path_parameters_file, "r") as f:
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpcaxjpoav/lithium-ion/anodes/tmpkrmqmi1z/parameters.csv'

======================================================================
FAIL: test_add_rm_param (test_parameters.test_parameters_cli.TestParametersCLI)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/alexander/projects/pybamm/tests/unit/test_parameters/test_parameters_cli.py", line 55, in test_add_rm_param
    self.assertTrue(os.path.isfile(new_parameter_filename))
AssertionError: False is not true

[brosaplanella]

I think the issue is that when you installed it that command hadn't been added. Because it acts on bash, you need to install it again (no need to clone again or anything, just re-run the installation command). @tlestang is that right?