Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ec sei bug #1397

Merged
merged 10 commits into from Mar 1, 2021
Merged

Ec sei bug #1397

merged 10 commits into from Mar 1, 2021

Conversation

valentinsulzer
Copy link
Member

Description

Fix some bugs in the non-dimensionalization of the EC SEI model.
Also capitalized SEI everywhere

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #1397 (93074ed) into develop (9a95deb) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1397      +/-   ##
===========================================
- Coverage    98.22%   98.22%   -0.01%     
===========================================
  Files          278      278              
  Lines        15806    15804       -2     
===========================================
- Hits         15526    15524       -2     
  Misses         280      280              
Impacted Files Coverage Δ
...models/submodels/interface/kinetics/no_reaction.py 100.00% <ø> (ø)
...amm/models/submodels/interface/sei/constant_sei.py 100.00% <ø> (ø)
pybamm/models/submodels/interface/sei/no_sei.py 100.00% <ø> (ø)
...odels/porosity/leading_reaction_driven_porosity.py 100.00% <ø> (ø)
pybamm/parameters/parameter_sets.py 100.00% <ø> (ø)
pybamm/parameters/parameter_values.py 99.41% <ø> (ø)
...m/models/full_battery_models/base_battery_model.py 99.68% <100.00%> (ø)
...ttery_models/lithium_ion/base_lithium_ion_model.py 100.00% <100.00%> (ø)
...bamm/models/full_battery_models/lithium_ion/dfn.py 100.00% <100.00%> (ø)
...bamm/models/full_battery_models/lithium_ion/spm.py 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a95deb...7ffd0ca. Read the comment docs.

Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Tino, thanks! We just need to update the CHANGELOG before merging

@valentinsulzer valentinsulzer merged commit 62610a5 into develop Mar 1, 2021
@valentinsulzer valentinsulzer deleted the ec-sei-bug branch March 1, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants