Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecker thermal params #1683

Merged
merged 6 commits into from Sep 24, 2021
Merged

Ecker thermal params #1683

merged 6 commits into from Sep 24, 2021

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Sep 20, 2021

Description

Add thermal parameters for the Ecker parameter set from "Modeling the effects of thermal gradients induced by tab and surface cooling on lithium ion cell performance" Zhao et al, 2018, and tab geometry from "The cell cooling coefficient: a standard to define heat rejection from lithium-ion batteries", Hales et al, 2019.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rtimms !

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #1683 (5ae1746) into develop (32a6a3e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1683   +/-   ##
========================================
  Coverage    99.27%   99.27%           
========================================
  Files          343      343           
  Lines        18744    18744           
========================================
  Hits         18609    18609           
  Misses         135      135           
Impacted Files Coverage Δ
pybamm/parameters/parameter_sets.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a6a3e...5ae1746. Read the comment docs.

@rtimms rtimms merged commit 97791d0 into develop Sep 24, 2021
@rtimms rtimms deleted the ecker-thermal-params branch September 24, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants