Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Li metal sei #1705

Merged
merged 7 commits into from Oct 6, 2021
Merged

Li metal sei #1705

merged 7 commits into from Oct 6, 2021

Conversation

valentinsulzer
Copy link
Member

Description

Reformat SEI models to work with half-cell models

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #1705 (2cc87c0) into develop (c737eac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #1705    +/-   ##
=========================================
  Coverage    99.27%   99.28%            
=========================================
  Files          343      343            
  Lines        18744    18864   +120     
=========================================
+ Hits         18609    18729   +120     
  Misses         135      135            
Impacted Files Coverage Δ
pybamm/models/submodels/electrode/ohm/__init__.py 100.00% <ø> (ø)
pybamm/parameters/parameter_sets.py 100.00% <ø> (ø)
...m/models/full_battery_models/base_battery_model.py 99.70% <100.00%> (+<0.01%) ⬆️
...l_battery_models/lead_acid/base_lead_acid_model.py 100.00% <100.00%> (ø)
...ttery_models/lithium_ion/base_lithium_ion_model.py 100.00% <100.00%> (ø)
...bamm/models/full_battery_models/lithium_ion/dfn.py 100.00% <100.00%> (ø)
pybamm/models/standard_variables.py 100.00% <100.00%> (ø)
pybamm/models/submodels/electrode/ohm/base_ohm.py 100.00% <100.00%> (ø)
pybamm/models/submodels/electrode/ohm/li_metal.py 100.00% <100.00%> (ø)
...lyte_conductivity/base_electrolyte_conductivity.py 98.96% <100.00%> (-0.05%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c737eac...2cc87c0. Read the comment docs.

Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Tino!

@valentinsulzer valentinsulzer merged commit 8025569 into develop Oct 6, 2021
@valentinsulzer valentinsulzer deleted the li-metal-sei branch October 6, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants