Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1481 update casadi interpolant #1791

Merged
merged 4 commits into from
Nov 11, 2021
Merged

#1481 update casadi interpolant #1791

merged 4 commits into from
Nov 11, 2021

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Nov 9, 2021

Description

Update the casadi interpolant to use "linear" or "bspline" and raise an error for "pchip".

Fixes #1481

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #1791 (ce88043) into develop (6e887ae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1791   +/-   ##
========================================
  Coverage    99.24%   99.24%           
========================================
  Files          343      343           
  Lines        18983    18989    +6     
========================================
+ Hits         18840    18846    +6     
  Misses         143      143           
Impacted Files Coverage Δ
...mm/expression_tree/operations/convert_to_casadi.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e887ae...ce88043. Read the comment docs.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valentinsulzer
Copy link
Member

needs a changelog

@rtimms rtimms merged commit 375fd53 into develop Nov 11, 2021
@rtimms rtimms deleted the issue-1481-casadi-interp branch November 11, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise warning when converting pchip interpolants to casadi
2 participants