Run tests once using coverage on ubuntu-latest with Python 3.9
#1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/test_on_push.yml
Outdated
| @@ -88,7 +92,7 @@ jobs: | |||
| if: matrix.os == 'ubuntu-latest' | |||
| run: tox -e examples | |||
|
|
|||
| - name: Install and run coverage | |||
| - name: Run unit tests for GNU/Linux with Python 3.9 and generate coverage report | |||
There was a problem hiding this comment.
Can we move this to line 78? Better to check the unit tests before integration tests and examples
Codecov Report
@@ Coverage Diff @@
## develop #1794 +/- ##
========================================
Coverage 99.24% 99.24%
========================================
Files 343 343
Lines 18983 18983
========================================
Hits 18840 18840
Misses 143 143 Continue to review full report at Codecov.
|
valentinsulzer
approved these changes
Nov 10, 2021
.github/workflows/test_on_push.yml
Outdated
| run: python -m tox -e quick | ||
|
|
||
| - name: Run unit tests for GNU/Linux with Python 3.9 and generate coverage report | ||
| if: success() && (matrix.os == 'ubuntu-latest' && matrix.python-version == 3.9) |
There was a problem hiding this comment.
not sure we need the if success here
Saransh-cpp
force-pushed
the
run-tests-once-using-coverage
branch
from
e845eb6
to
0e08601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ubuntu-latestwith Python3.9ubuntu-latestSpeeds up the CI by 15-30 mins!
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: