Skip to content

Marcus Hush chidsey kinetics - #1858

Merged
valentinsulzer merged 8 commits into
developfrom
marcus-husch-chidsey
Dec 14, 2021
Merged

Marcus Hush chidsey kinetics#1858
valentinsulzer merged 8 commits into
developfrom
marcus-husch-chidsey

Conversation

@valentinsulzer

Copy link
Copy Markdown
Member

Description

Add new kinetics, including asymmetric Butler-Volmer, linear, and MHC

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@brosaplanella brosaplanella left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Tino!

import pybamm

pybamm.set_logging_level("INFO")
pybamm.set_logging_level("DEBUG")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set it back to INFO?

@valentinsulzer
valentinsulzer merged commit 85c66a7 into develop Dec 14, 2021
@valentinsulzer
valentinsulzer deleted the marcus-husch-chidsey branch December 14, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants